Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor improvements to dist app builder config #6524

Merged
merged 3 commits into from
Oct 29, 2024

Conversation

JamesNK
Copy link
Member

@JamesNK JamesNK commented Oct 28, 2024

Description

Some minor things I noticed while looking at app host config

  • Don't calculate sha then throw it away
  • Explicitly set resource service config to unsecured when unsecured

Checklist

  • Is this feature complete?
    • Yes. Ready to ship.
    • No. Follow-up changes expected.
  • Are you including unit tests for the changes and scenario tests if relevant?
    • Yes
    • No
  • Did you add public API?
    • Yes
      • If yes, did you have an API Review for it?
        • Yes
        • No
      • Did you add <remarks /> and <code /> elements on your triple slash comments?
        • Yes
        • No
    • No
  • Does the change make any security assumptions or guarantees?
    • Yes
      • If yes, have you done a threat model and had a security review?
        • Yes
        • No
    • No
  • Does the change require an update in our Aspire docs?
Microsoft Reviewers: Open in CodeFlow

@JamesNK JamesNK added the area-app-model Issues pertaining to the APIs in Aspire.Hosting, e.g. DistributedApplication label Oct 28, 2024
@JamesNK JamesNK force-pushed the jamesnk/minor-dist-app-builder branch from 0a79342 to 8b07d9a Compare October 29, 2024 05:27
@JamesNK JamesNK enabled auto-merge (squash) October 29, 2024 06:13
@JamesNK
Copy link
Member Author

JamesNK commented Oct 29, 2024

/azp run

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@JamesNK JamesNK merged commit 53f4daa into main Oct 29, 2024
9 checks passed
@JamesNK JamesNK deleted the jamesnk/minor-dist-app-builder branch October 29, 2024 09:53
@davidfowl davidfowl added this to the 9.1 milestone Oct 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-app-model Issues pertaining to the APIs in Aspire.Hosting, e.g. DistributedApplication
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants